search

League-of-Fabulous-Developers / FoundryVTT-Fabula-Ultima

Enter Project FU: an unofficial foundry system for Fabula Ultima, channeling the essence of the book while delivering the immersive experience of playing a JRPG in tabletop format.
MIT License
40 stars 18 forks source link

Dual Shields don't benefit from Weapon Category Accuracy bonuses. #73

Closed Cosmic-Cocoa closed 8 months ago

Cosmic-Cocoa commented 8 months ago

Bug Description: Dual Shield Equipment does not benefit from active effects that grant an accuracy bonus to specific weapon categories.

Steps to Reproduce:

  1. Add a Dual Shield in the Brawling category to the equipment of a character.
  2. Add an active effect granting a bonus to the system.bonuses.accuracy.brawling attribute key.
  3. Make an attack with the shield.

Expected behavior: I expected there to be a +4 bonus to the Twin Shield's accuracy check. Basically, I figured it would work just like it does if you add a bonus to the system.bonuses.accuracy.accuracyCheck attribute key.

Attachments (if applicable): shieldItem

activeAccuracyEffect

attackRoll

spyrella commented 8 months ago

Sorry, late to this issue.

Trying to wrap my head around where your problem is stemming from, I think it was perhaps fixed in the dev version when we switched to the new roll system: image

Cosmic-Cocoa commented 8 months ago

No worries at all.

And sweet! In the game I'm playing in we just added the modifier in the item itself as a work around. We absolutely love the implementation in Foundry so I wanted to report it in case it was helpful to you guys.