search

League-of-Foundry-Developers / compendium-browser

A module to easily browse and filter spells as well as npcs loaded from compendie
9 stars 18 forks source link

Abandoned or is V10 support going to happen? #39

Closed joevaughan closed 2 years ago

joevaughan commented 2 years ago

Question: Is this abandoned? - Hasn't been updated since Jan and bugs open since then.

If not abandoned: Is someone looking at V10 support/changes? I don't think it will take a great deal as compendiums haven't had massive core changes in V10 (unlike, e.g. Journals).

spetzel2020 commented 2 years ago

Although I don't "own" this, I think I'm the one who's been maintaining compatibility. Unfortunately I have my hands full with bringing Quick Encounters up-to-date which is consuming all my time (because of the Journal changes).

On Wed, Aug 31, 2022 at 7:35 AM joevaughan @.***> wrote:

Question: Is this abandoned? - Hasn't been updated since Jan and bugs open since then.

If not abandoned: Is someone looking at V10 support/changes? I don't think it will take a great deal as compendiums haven't had massive core changes in V10 (unlike, e.g. Journals).

— Reply to this email directly, view it on GitHub https://github.com/League-of-Foundry-Developers/compendium-browser/issues/39, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACSZYWXFNAEQAWVVTHO4WIDV35UTBANCNFSM6AAAAAAQBOCWJY . You are receiving this because you are subscribed to this thread.Message ID: @.***>

joevaughan commented 2 years ago

Thanks for all your hard work @spetzel2020 (and all or the League :D)

FWIW: I forked and simply updated the module.json to enable compatability with v10 and I would say it appears to be 95% functioning (I've only come across one weird error which I haven't yet been able to verify is definitely a bug or a consequence of my environment/foundry-setup)

Will continue my 'hacky' messing around with same. Was just curious if I was wasting my time (i.e. is someone already doing this).

bradleyquinn commented 2 years ago

I appreciate anyone that is willing to bring this up to v10 support. I am completely lost without it.

joevaughan commented 2 years ago

I appreciate anyone that is willing to bring this up to v10 support. I am completely lost without it.

I have it working.

Item, spell and Feat browsers work 'out-of-the-box' anyway as far as I can tell (let me know if that's not the case for you).

The NPC browser doesn't work (for me) because of a change to the data model. (Actor.data is now Actor.system).

I have just hacked mine to make it v10 compatible but that's not right. I need to roll back my changes and engineer properly to make it handle both v8+9 and v10 and then I'll submit a PR.

However, right now I'm going to bed to nurse this stinking cold I've picked up so will look at it tomorrow :D

spetzel2020 commented 2 years ago

Thanks Joe. Ping me directly (spetzel#0103 on Discord) if nobody responds promptly after you submit the PR.

On Sat, Sep 10, 2022, 2:34 AM joevaughan @.***> wrote:

I appreciate anyone that is willing to bring this up to v10 support. I am completely lost without it.

I have it working.

Item, spell and Feat browsers work 'out-of-the-box' anyway as far as I can tell (let me know if that's not the case for you).

The NPC browser doesn't work (for me) because of a change to the data model. (Actor.data is now Actor.system).

I have just hacked mine to make it v10 compatible but that's not right. I need to roll back my changes and engineer properly to make it handle both v8+9 and v10 and then I'll submit a PR.

However, right now I'm going to bed to nurse this stinking cold I've picked up so will look at it tomorrow :D

— Reply to this email directly, view it on GitHub https://github.com/League-of-Foundry-Developers/compendium-browser/issues/39#issuecomment-1242052784, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACSZYWSYEDMFM4GZTQYXISTV5NDHHANCNFSM6AAAAAAQBOCWJY . You are receiving this because you were mentioned.Message ID: <League-of-Foundry-Developers/compendium-browser/issues/39/1242052784@ github.com>

Alixzer commented 2 years ago

I took a look at it myself, but unfortunately my brain falls apart when it comes to this kind of stuff. Good luck to fixing it, as the only feature I use out of it for my games is the npc browser

joevaughan commented 2 years ago

Apologies. Was Flu'ed up since Friday. Submitted PR today. Hopefully works (definitely works for me :D)

joevaughan commented 2 years ago

@Alixzer, @bradleyquinn - Just to say: @spetzel2020 has merged the v10 code into the main branch now and will do a release some time soon (but please just have a little more patience as he's not at home at the moment - is in a whole other timezone - so doing a build and release isn't easy). Once he does that release I'll close this.

joevaughan commented 2 years ago

V10 supporting release (0.8.1) published by @spetzel2020 on Sept 16th. Closing.