search

League-of-Foundry-Developers / compendium-browser

A module to easily browse and filter spells as well as npcs loaded from compendie
9 stars 18 forks source link

Unable to filter spells by Class and + #43

Open eduardopato41 opened 2 years ago

eduardopato41 commented 2 years ago

So, after the last update I'm unable to filter spells (from a compendium, inside a module that I created) by class. And Monsters on my compendium (same situation from spells) are not showing up anymore. Again, until the latest update every filter was working. Did anything change in the spell-classes file that my custom one (with the spells in pt-br) stopped working?

I'm also unable to drag spells from the browser (this module) to a player sheet (but I think this one already has a issue about it open).

Spells: image image

NPCs: image image image

Thanks for keeping this module alive!

joevaughan commented 2 years ago

Can you show what version of Foundry you're using please.

Can you show your settings (with the selected compendiums for these) and confirm if these are 'standard' compendiums or custom?

Can you disable all modules except Compendium Browser and then open the DEV Console (Just press the F12 key in most browsers) - Can you paste any error messages you're getting from Compendium Browser in the console log while trying to search.

One of the things I did find doing the updates to this module to get it to work with V10 was that some compendiums use Actor.data or Item.data structures (JB2A for example) which are not the V10 format (Actor.system and Item.system). If these compendiums have not been migrated to the V10 format they can't be searched by this version of Compendium Browser. If this is the case, there will be a message in the console log about it. Speak to the compendium supplier about getting their compendium set up for doing a V10 migration.

eduardopato41 commented 2 years ago

I'm using 10.285 (prob gonna update later this week) image

I don't think I'm getting a error with Compendium Browser. I used Find the Culprit to enable only CB and tried to filter with the Spells on the SRD Compendium and i'm not getting anything. image

About the settings from my Compendiums, I don't really know what information you want. Theses Compendiums were created by me and I created a module to share with my other worlds (back in v8). So I can't really ask for a migration because I don't know how to do it. I tried to use the SRD Monsters and it's working on CB, so there's definitely something wrong with my compendium. Maybe I really need to migrate the Monsters Compendium but I'll need to look into how to do it haha

eduardopato41 commented 2 years ago

My compendiums on the CD's Settings:

image

image

joevaughan commented 2 years ago

About the settings from my Compendiums, I don't really know what information you want. Theses Compendiums were created by me and I created a module to share with my other worlds (back in v8). So I can't really ask for a migration because I don't know how to do it. I tried to use the SRD Monsters and it's working on CB, so there's definitely something wrong with my compendium. Maybe I really need to migrate the Monsters Compendium but I'll need to look into how to do it haha

From what I observed with JB2A (and I'm by no means an expert) it seems to be that you need to move Actor.data to Actor.system and Item.data to Item.system.

That may be enough but I suspect there are nuances.

For instance: I believe in some cases (maybe all but I can't be sure, check the docs and the Foundry Discord to confirm) Item.data.data.XXX has also been 'folded down' to Item.system.XXX

The CB is checking if you're running V10 but have compendiums with Item.data or Actor.data entries and it ignores them (it should somewhere in the log be saying this... I'm surprised not to see it in your console log. I'll check that).

eduardopato41 commented 2 years ago

The CB is checking if you're running V10 but have compendiums with Item.data or Actor.data entries and it ignores them (it should somewhere in the log be saying this... I'm surprised not to see it in your console log. I'll check that).

I guess you were right haha After updating a actor on my compendium, the monster appeared on CB. So I made small changes and reverted them back and now all my monsters are showing. Maybe Foundry did not update the compendium or it only updates after updating the actor? I don't know :( and I'm not sure if there's a better way for doing that but I didn't find anything.

About the spells, any idea of what's happening? It's so useful to filter them by class and dragging and dropping on the players sheets (for clerics and paladins especially haha) :(

joevaughan commented 2 years ago

About the spells, any idea of what's happening? It's so useful to filter them by class and dragging and dropping on the players sheets (for clerics and paladins especially haha) :(

It's a bug. I've fixed it the PR I've just added. Just need to wait for @spetzel2020 to review (hopefully) approve and build 0.8.2

spetzel2020 commented 2 years ago

Noted - will plan to do this today. I have also asked about adding you to list of reviewers/releasers if that's ok.

On Fri, Sep 23, 2022 at 2:25 AM joevaughan @.***> wrote:

About the spells, any idea of what's happening? It's so useful to filter them by class and dragging and dropping on the players sheets (for clerics and paladins especially haha) :(

It's a bug. I've fixed it the PR I've just added. Just need to wait for @spetzel2020 https://github.com/spetzel2020 to review (hopefully) approve and build 0.8.2

— Reply to this email directly, view it on GitHub https://github.com/League-of-Foundry-Developers/compendium-browser/issues/43#issuecomment-1255985370, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACSZYWXZTMZYRBJZPDYTO73V7VZQPANCNFSM6AAAAAAQPLIBQU . You are receiving this because you were mentioned.Message ID: <League-of-Foundry-Developers/compendium-browser/issues/43/1255985370@ github.com>

zloveless commented 1 year ago

Curious bug. When I went to install this, Foundry (latest; v10.291) pulled 0.8.1. however, I just hit update next to the module and it grabbed 0.8.2 and now I can filter by class. Thanks for the fix though.

alessiocali commented 1 year ago

Class filter broke again - the "classes" property path changed from "system.classes" to just "classes" in the latest DnD system update.

alessiocali commented 1 year ago

Actually this has been fixed by @spetzel2020 , but the version that I downloaded for foundry wasn't fixed. Can the maintainer issue a new release?

NeatoJiraffe commented 1 year ago

I can also confirm class filtering isn't working. Foundry V10 291, D&D 5e v2.1.4.

Latest module version v0.8.1. I got it working by changing 'system.classes' to 'classes' on Ln 1411.

CanadaBry commented 1 year ago

I can also confirm class filtering isn't working. Foundry V10 291, D&D 5e v2.1.4.

Latest module version v0.8.1. I got it working by changing 'system.classes' to 'classes' on Ln 1411.

Thanks. This worked for me as well! Using Foundry V10 291 and D&D 5e v2.1.5

Updated to v0.8.2 using GH release and it is fixed there. Module installed directly in Foundry is still v0.8.1 though.