League-of-Foundry-Developers / foundry-vtt-types

Unofficial type declarations for the Foundry Virtual Tabletop API
MIT License
118 stars 56 forks source link

Version 12.331 #2542

Open JPMeehan opened 6 months ago

JPMeehan commented 6 months ago

Task list

Client

Client-ESM

Common

JPMeehan commented 6 months ago

Context: v12.324 was v12 stable 1

JPMeehan commented 5 months ago

v12 stable is about to drop and seems as good a target as any.

JPMeehan commented 5 months ago

Basic categories of things

Abourass commented 4 months ago

Just to be clear, is work on this to be forked from the V12 branch or the main branch?

The read-me suggest the main branch is where the current FVTT version is being worked on, but it seems most of the PR I see are from the V12 branch. I'd like to contribute some work on this, and just want to be sure where I should dig in?

JPMeehan commented 4 months ago

Just to be clear, is work on this to be forked from the V12 branch or the main branch?

The read-me suggest the main branch is where the current FVTT version is being worked on, but it seems most of the PR I see are from the V12 branch. I'd like to contribute some work on this, and just want to be sure where I should dig in?

  1. We have a work group in the League discord, in the fvtt-types-qwest channel.
  2. Normally work is branched from main but there's a bit of a holdup due to working out some data field related issues in v11/data-models, so we made v12/main to allow work on v12 to progress forward while those were resolved
  3. I strongly suggest picking any of the "Good First Issues", making a PR, and then we can fill you in. A lot of the Contributing documentation hasn't been revised in a few years and so we'll probably provide more specific feedback than is in those docs, we're kinda playing catchup after stalling out due to some Typescript bugs blocking a proper implementation of data models.
kmoschcau commented 1 month ago

@JPMeehan can you please add a remark to also update common/documents/_types.d.mts when updating any of these: BaseAmbientSound, BaseScene, BaseRegion and BaseRegionBehavior?