Allow interior `SchemaField` and `EmbeddedDataField` instances to take `undefined` or `null` if they can be initialized

League-of-Foundry-Developers / foundry-vtt-types

Unofficial type declarations for the Foundry Virtual Tabletop API

MIT License

112 stars 54 forks source link

Open JPMeehan opened 2 months ago

JPMeehan commented 2 months ago

[ ] The darkness field in foundry.documents.BaseAmbientSound is a SchemaField that is not required and can be safely initialized from a value of an explicit undefined or null, but currently errors in the tests
[ ] The texture field of foundry.documents.BaseNote is an EmbeddedDataField that is not required and can be safely initialized from a value of an explicit undefined or null, but currently errors in the tests

LukeAbby commented 2 months ago

This is a part of the broader issue that the check for if field.initial can be assigned to the field's assignment type is incomplete.