search

League-of-Foundry-Developers / foundryvtt-devMode

A module with some tools to help enable Foundry VTT package developers.
MIT License
12 stars 15 forks source link

Module JSON Changes getting triggered for modules using `entity` in their packs in v9 #26

Closed arcanistzed closed 2 years ago

arcanistzed commented 3 years ago

Environment Details

Describe the bug The new "Module JSON Changes" feature is getting triggered when using a module that still uses the entity field in their packs in v9. Core changes this field to type which make Dev Mode think it was changed.

To Reproduce Steps to reproduce the behavior:

  1. Install module using entity in packs on a v9 instance
  2. See notification and console message describing a change

Expected behavior I would expect Dev Mode to detect if this is the only change before alerting me. Otherwise, it could be beneficial to allow users to choose only certain modules which they care about changes to (perhaps keyed off of the author name).

Screenshots image

akrigline commented 2 years ago

@arcanistzed can you re-test this on latest v9 stable, this might have been solved by something core did.

arcanistzed commented 2 years ago

@akrigline Nope. I tested again with MidiQoL on 9.242 and it still happens