League-of-Foundry-Developers / foundryvtt-forien-copy-environment

8 stars 7 forks source link

[BUG] Import still does not work in 2.1.1 #25

Closed Zamrod closed 2 years ago

Zamrod commented 2 years ago

Describe the bug Issue #21 does not appear to be fixed in this release. When I import a JSON file, no dialog comes up and nothing happens. The only thing I see is a console message that says:

Copy Environment | Parsing provided settings (296)

Which is then followed by all my settings. But nothing happens afterwards.

esheyw commented 2 years ago

+1, same symptoms. Silent failure except for the parsing message. Parse looks accurate and complete at least?

sneat commented 2 years ago

@Zamrod @esheyw Please make sure you are importing a new export, the issue was actually in the export rather than the import, so an existing export would still be missing the data.

If you are using a current export, please ping me on discord to share your json file. blair#9056

sneat commented 2 years ago

@Zamrod before I merge it, would you mind testing v2.1.2 for me to make sure it's all working correctly now? You can download a zip from the top right green Code button at https://github.com/League-of-Foundry-Developers/foundryvtt-forien-copy-environment/tree/2.1.2

Zamrod commented 2 years ago

Looks like it works.

On Sun, May 22, 2022 at 3:48 AM Blair @.***> wrote:

@Zamrod https://github.com/Zamrod before I merge it, would you mind testing v2.1.2 for me to make sure it's all working correctly now? You can download a zip from the top right green Code button at https://github.com/League-of-Foundry-Developers/foundryvtt-forien-copy-environment/tree/2.1.2

— Reply to this email directly, view it on GitHub https://github.com/League-of-Foundry-Developers/foundryvtt-forien-copy-environment/issues/25#issuecomment-1133847037, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC75BGLFMZMROUOW27VNBXLVLHYG7ANCNFSM5WRJIDSA . You are receiving this because you were mentioned.Message ID: <League-of-Foundry-Developers/foundryvtt-forien-copy-environment/issues/25/1133847037 @github.com>

-- Chris Wachal

sneat commented 2 years ago

Have released v2.1.2 - thank you ❤️