search

League-of-Foundry-Developers / foundryvtt-forien-copy-environment

8 stars 7 forks source link

[BUG] Error with a particular JSON reimport #7

Closed Norc closed 1 year ago

Norc commented 3 years ago

Describe the bug Error thrown when reloading a copied environment. Reported on the behalf of BigMatt500#0974 and not personally reproduced.

To Reproduce Steps to reproduce the behavior:

  1. Try to reimport attached file

Expected behavior The settings should be loaded as described.

Screenshots image

Browser: Unknown

Foundry Version: 0.7.10 System:

Additional context

BigMatt500_foundry-environment.json.txt (text-ified for uploading purposes)

Tyreal74 commented 3 years ago

I was just coming to write the same Bug report.

Some additional information though, only seems to happen on certain key imports, I could bring in some basic settings but if i imported say core or tokenmagicfx it failed.

sneat commented 3 years ago

Fixed in v2.0.5

Tyreal74 commented 3 years ago

Hi,

this still isnt fixed im afraid. I uninstalled and reinstalled using the Raw url from the github, but still the same, Foundry 7.10 Untitled-1

sneat commented 3 years ago

@Tyreal74 or @Norc are you able to send me the file generated by the Export Settings option please?

image

The one attached to this issue is the output of the Save as JSON option (which can't be imported).

I still haven't been able to replicate this locally, so need one of the versions that are causing the issue.

Tyreal74 commented 3 years ago

Please find attached - sorry for the wait :) Just remove the txt foundry-settings-export (2).json.txt

Thanks

sneat commented 2 years ago

Thanks for that @Tyreal74

I haven't been able to get the error to appear locally or on the forge :( Your provided file worked correctly, even when I created players with the same names.

Do you see the import dialog that shows the diff, or do you get the error as soon as you select the file?

Can you also please confirm that you're running version 2.0.6?

Tyreal74 commented 2 years ago

I'm running 2.06 yes, it happens soon as I click on import.

I was running 7.10, but recently upgraded to 8.8, I've tried the import again on 8.8 and that was successful so seems to be related to 7.10

sneat commented 2 years ago

That's helpful, thanks @Tyreal74

Unfortunately, I still can't replicate it, even on 0.7.10.

image

I assume since you've upgraded to 8.8 you won't be able to replicate it any more. It would have been good to see the error console in case it provided a line number or anything like that.

Tyreal74 commented 2 years ago

Yeah sorry, needed to upgrade due to a game. I'll try it on my local instance as that's still on 7.10

On Fri, 23 Jul 2021, 03:38 Blair, @.***> wrote:

That's helpful, thanks @Tyreal74 https://github.com/Tyreal74

Unfortunately, I still can't replicate it, even on 0.7.10.

[image: image] https://user-images.githubusercontent.com/293277/126731411-7a05f038-cbe2-4209-9750-d4291a7e85a6.png

I assume since you've upgraded to 8.8 you won't be able to replicate it any more. It would have been good to see the error console in case it provided a line number or anything like that.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/League-of-Foundry-Developers/foundryvtt-forien-copy-environment/issues/7#issuecomment-885360033, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE5ZXWYLGP342TQOBIRGXPLTZDIZ7ANCNFSM46S2TDRA .

sneat commented 1 year ago

Closing as I believe this has been fixed already but didn't get any feedback. Please re-open if it's still an issue and we can debug again.