search

League-of-Foundry-Developers / fvtt-module-furnace

34 stars 12 forks source link

Furnace prevents menus from closing in Foundry 0.7.6 #83

Closed velara closed 3 years ago

velara commented 3 years ago

Description of the Bug: Menus fail to close upon pressing the [ x ] button. Menus closed in this fashion successfully close when the page is refreshed. Menus can still be minimized by double clicking, but fail to close, regardless until a refresh is performed. When tested on Foundry without any modules this behaviour vanishes.

No error is found in the debug menu. However if I change the text opacity the following error is produced: foundry.js:5548 You are using the validateForm(formData) function which has been deprecated in favor of the FormApplication.processForm static method

Reproduction: I've been reliably able to reproduce this bug using Drawing tools, I've tested both the square and text drawing tools. I had intially suspected it affected other menus as well as it also occurred when attempting to modify dice so nice settings. However, subsequent testing proved that Dice so Nice had the same issue on its own. I have also found that the issue does not occur with the wall menu indicating that this issue appears to be isolated to the modified drawing menus.

I've reproduced the issue in an empty PF2 world with the Furnace as the only active module.

velara commented 3 years ago

Issue vanished as mysteriously as it appeared. It has been suggested to me that I experienced a local javascript problem that effected your module among others. Rather than an issue that was specific to your module.

Apologies, I tried so hard to validate this before posting.

velara commented 3 years ago

Turns out the issue vanished because I hadn't tried to save/update the drawing config menu. A solution has been found by the developers of Dice so Nice and I've posted more info on the fresh bug report on this same topic.