search

League-of-Foundry-Developers / fvtt-module-furnace

34 stars 12 forks source link

0.7.6 Drawing Tools can't close with Furnace active #84

Closed frvwfr2 closed 3 years ago

frvwfr2 commented 3 years ago

With Furnace active, the Drawing Tools config no longer is able to close.

velara commented 3 years ago

Dice so nice was effected by the same issue. And they've found the fix. Their herited FormApplication wasn't closing anymore on a submit since 0.7.6. It was because their override of the "close" method wasn't passing the parameters and 0.7.6 introduced a new option that was needed in this case (the "force" option). Thanks to JDW for figuring the issue out.

To be specific the drawing tools config should be able to close, until you use the update/save button after which point the close button will no longer function.

Just in case you find it useful, I included some steps for reproduction and what not when I first filed the bug https://github.com/kakaroto/fvtt-module-furnace/issues/83

I then closed it because I thought it was a local issue because it went away. Turns out that was because I had reloaded everything and hadn’t pressed the save/update button so the close button still worked.

amcvfx commented 3 years ago

I am assuming a fix for this will be on the way? :)

kakaroto commented 3 years ago

Thanks for the report and @velara for the passing along of info from JDW's research. (woahhhh, your text just changed under my eyes! either you just edited, or I really need to sleep!!!) Will fix. Good night!

velara commented 3 years ago

Changing lines 191 and 192 of DrawingConfig.js to close(options) { super.close(options);

Appears to have resolved this issue for me. With the caveat that I have not done extensive testing. Just a quick attempt to update some text and the issue was no longer present.