League-of-Foundry-Developers / fvtt-module-popout

FVTT Module PopOut!
Other
29 stars 24 forks source link

Version 12 compatibility? #121

Open Eireman opened 5 months ago

Eireman commented 5 months ago

I have been asked to test V12 but this module shows total incompatibility. As I and others stream our game, I have opted to wait until needed modules are updated.

Posnet commented 5 months ago

Hi, @Eireman I only support current stable foundry released and one major version less.

Krigsmaskine commented 5 months ago

Seeing as version 12 now is the stable release (since less than 24 hours ago), will that be v11 and v12? 😛

edit: this comment was intended as a joke at v12 suddenly dropping, take your time updating, appreciate the maintaining

Eireman commented 5 months ago

What @Krigsmaskine said.

Eireman commented 5 months ago

Sorry to nag, but it has been a week since V12.xxx launched. Is there any idea as to when compatible code for V12 will be ready for our use? I prefer to have the latest Foundry running, but your PopOut module is currently key in how my stream (and that of the players, who are all also streamers) use Foundry.

Peddro commented 5 months ago

+1 - I also need this. I was trying to edit manually the min version but since the module does not appear on any search I can't really do that 😞

iLLHunter commented 5 months ago

I also would like to use this module on the current stable release, v12

majeric commented 5 months ago

yes please. :)

LivinBreezy commented 5 months ago

For anyone here who wants the functionality, it looks as though it works in v12 as-is.

Until there's an official update, you just need to go to the "Add-on Modules" tab in the main Foundry screen, right click the Pop-Up! addon, click "Edit Module", then change the Verified Version to 12 and click the "Edit Module" button at the bottom. Restart Foundry and it should work again.

I don't know if there are any bugs associated with it, since obviously it's built for v11, but it seems to work in my Call of Cthulhu game, including dice rolls.

Peddro commented 5 months ago

For anyone here who wants the functionality, it looks as though it works in v12 as-is.

Until there's an official update, you just need to go to the "Add-on Modules" tab in the main Foundry screen, right click the Pop-Up! addon, click "Edit Module", then change the Verified Version to 12 and click the "Edit Module" button at the bottom. Restart Foundry and it should work again.

I don't know if there are any bugs associated with it, since obviously it's built for v11, but it seems to work in my Call of Cthulhu game, including dice rolls.

this may be a solution if you already had the Pop-out addon installed. If you didn't, can't even import it from the list

LivinBreezy commented 5 months ago

For anyone here who wants the functionality, it looks as though it works in v12 as-is. Until there's an official update, you just need to go to the "Add-on Modules" tab in the main Foundry screen, right click the Pop-Up! addon, click "Edit Module", then change the Verified Version to 12 and click the "Edit Module" button at the bottom. Restart Foundry and it should work again. I don't know if there are any bugs associated with it, since obviously it's built for v11, but it seems to work in my Call of Cthulhu game, including dice rolls.

this may be a solution if you already had the Pop-out addon installed. If you didn't, can't even import it from the list

You should still be able to install it manually. On the main Code tab of the repo, go to Releases and download the Source for v2.15 as a ZIP. It'll give you a folder you can drop into FoundryVTT\Data\modules (which is usually in your AppData's Local folder on Windows, for example) and rename it popout. Restart Foundry and it will appear in the addon list and you can edit it however you'd like as normal.

BrownSamurai commented 5 months ago

You should still be able to install it manually. On the main Code tab of the repo, go to Releases and download the Source for v2.15 as a ZIP. It'll give you a folder you can drop into FoundryVTT\Data\modules (which is usually in your AppData's Local folder on Windows, for example) and rename it popout. Restart Foundry and it will appear in the addon list and you can edit it however you'd like as normal.

This does not work. The module does appear in the modules list, but Foundry will not allow it to load into the worlds themselves. Hopefully this gets fixed - it's a great module.

Popout Sad Face

LivinBreezy commented 5 months ago

This does not work. The module does appear in the modules list, but Foundry will not allow it to load into the worlds themselves. Hopefully this gets fixed - it's a great module.

I think you've edited the 2.15 to be 2.16, which is not what you should change. That's just a cosmetic package (module) version number and Foundry doesn't really care what it is. I'd recommend putting it back to 2.15 so that when PopOut! officially updates to whatever the module version is, Foundry will replace your changes.

Edit: Just to clarify, the package version, 2.15, is cosmetic as it relates to how the module functions when it's already installed. Changing that number doesn't change how Foundry views it in terms of its compatibility. What it does potentially affect is whether or not Foundry will try to update it. If you change the package version from 2.15 to 2.20 (as an example) and then the module is officially updated to version 2.16, Foundry may see 2.20 as newer than 2.16 and not update it automatically until the official release patch number goes higher than 2.20. Best to leave the package version number alone to avoid that kind of issue.

What you need to change is in the compatibility section. That tells Foundry which versions of Foundry the module is compatible with. It starts out compatible with minimally v10 and maximum v11, which a verified version of 11. The verified version is the version of Foundry the developer confirms the module works on, probably when they were testing it. You want to change these values so that it's verified and maximum 12, as seen here:

image

Once you change those, restart Foundry and it should show up green in the mod list, like this:

image

At this point, you should be able to load it in game worlds again. I can confirm this works because I've been using the module since Foundry v12 was released.

BrownSamurai commented 4 months ago

I didn't change the module (2.16 is the version from the master branch on github), but I also didn't know you could muck with the version compatibility. I modified it as you indicated, selected 'create module', but it still didn't work as expected. The good news is there is a v12 (2.17) branch in test that seems to work.

Thanks for teaching me about the additional properties of modules!

WBHarry commented 2 months ago

I just put up a Pull Request that makes Popout work with V2 Applications 😎