League-of-Foundry-Developers / fvtt-module-theatre

GNU General Public License v3.0
30 stars 39 forks source link

Replace the old webfontloader with ffontsloader #144

Closed p4535992 closed 11 months ago

p4535992 commented 1 year ago

Hi the version of webfontloader was very old and doesn't seem to be followed anymore. I found an opensource project with the same license and newer that seems to work well, https://github.com/MurDaD/ffontsloader

Try to have a look at it just in case or put the latest version of webfontloader in the project (we were on the third last one)

megahead11 commented 11 months ago

I'll try and give this a test before I merge this; might need a day or so

megahead11 commented 11 months ago

On initial testing, for whatever reasons, it doesn't seem to initialize the UI for theatre (on the right side), I receive this error on my empty world (with this and anonymous enabled). The issue still happens even with theatre on its own. image

p4535992 commented 11 months ago

Exported the constants on the theatre class should be fixed this issue... next pr i will create a constants file for a cleaner code I HAVENT TESTED YET IF YOU WANT TO WAIT MY CONFIRMATION

p4535992 commented 11 months ago

k should be working now, try out and let me know it

megahead11 commented 11 months ago

Looks good! I'll go ahead and merge this.

p4535992 commented 11 months ago

@megahead11 i made a mistake on this pr can you add this two lines to the renderChatLog hook after the initialize method ?

Hooks.on("renderChatLog", function (app, html, data) { if (data.cssId === "chat-popout") return; theatre.initialize();

window.Theatre = {}; window.Theatre.instance = theatre;