search

League-of-Foundry-Developers / fvtt-module-theatre

GNU General Public License v3.0
30 stars 39 forks source link

[BUG] Update compatibility with Argon 2.0 #159

Open kaelad02 opened 9 months ago

kaelad02 commented 9 months ago

Module Version: v2.6.1

Describe the bug The new Argon 2.0 update split that module in two, similar to what happened with Token Action HUD. That is causing an error when both Theatre Inserts and Argon are enabled when Theatre Inserts tries to use libWrapper on a function from Argon. Confirmed by TheRipper93, developer of Argon, on Discord that the function doesn't exist in the new version.

The original module ID, enhancedcombathud, is now the Argon Core module and a new module ID, enhancedcombathud-dnd5e, is the Argon DnD5e module.

To Reproduce Steps to reproduce the behavior:

  1. Enable the Argon HUD module
  2. In the Theatre Inserts module settings, enable "Hide Bottom UI Elements Automatically"
  3. Reload Foundry
  4. Open Browser console and see the libWrapper error

Expected behavior shouldn't get this error

Screenshots image

Browser:

Foundry Version:

Game System:

Additional context I'm filing this bug on behalf of another user on the main Foundry Discord server, which is why I don't have some of the info at the bottom. I don't think it's all that relevant though, so hopefully it won't be an issue.

HumanDM commented 9 months ago

To add the possibly crucial data to help resolve. I am that user Kaelad02 mention. (First Github comment Yippee)

Browser: I was using the downloaded application and didn't extend to Chrome or Edge at the time of discovery.

Foundry Version: 11 Build 315

Game System: DnD5e - Fifth Edition System

megahead11 commented 7 months ago

As far as I am aware, this issue doesnt occur in 2.8.0, but I will wait and see if OP has updated to it to see if this still occurs.

HumanDM commented 7 months ago

In all honesty I am unsure of which you mean. Does (2.8.0) belong to theater? If so where may I find that? This is what FoundryVTT is telling me in summery in regards of updates.

Could I be looking in the wrong area or am I missing something else entirely?

megahead11 commented 7 months ago

Sorry, I was unclear. IF you try and update theatre inserts through foundry, it will only update to v2.6.1 due to issues with foundry not pulling the latest version. To download it, you need to go to here https://github.com/League-of-Foundry-Developers/fvtt-module-theatre/releases/tag/v2.8.0 and install it via the manifest (.json).

HumanDM commented 7 months ago

Thank you for clarifying. It is now up to date with v2.8.0 and it seems to be doing the same thing as before. If I uncheck the "Hide Bottom UI Elements Automatically" and refresh, this seems to not bring up the error. While on and refreshed it will pop up. It does seem to work as intended solo but the error is concerning. I have not tried it with my players yet. Here is a screenshot.

Screenshot (128)