search

League-of-Foundry-Developers / fvtt-module-theatre

GNU General Public License v3.0
30 stars 39 forks source link

Adds the Speaker's Scene to the Chat Message #164

Closed elizeuangelo closed 6 months ago

elizeuangelo commented 6 months ago

Some other modules like Automated Animations actually use the speaker scene data and they become incompatible with Theatre Inserts because of the ChatData override, wich removes lot of the message information.

I have not refactored the entire preCreateMessage because i'm not that familiar to take that risk but I have not seen any other functions in the module using the speaker scene data.

megahead11 commented 6 months ago

I believe this might have unexpected effects with chat portrait or PF2e. but I will have to check. I believe the actor data (actor name) has caused issues before in regards to certain chat cards functioning

megahead11 commented 6 months ago

It appears to be working on my end -- my concerns don't seem to be happening, so it seems good so far, but I'll see if p4535992 has anything to say