League-of-Foundry-Developers / fvtt-module-theatre

GNU General Public License v3.0
30 stars 39 forks source link

[BUG] Compatibility with Ready Set Roll for 5E #168

Open Wokeye27 opened 4 months ago

Wokeye27 commented 4 months ago

Module Version: v2.8.0 on Forge Hosting Ready set roll 3.0.14

Describe the bug Attacks won't up roll on the chat log with both modules enabled. I tried turning off all other modules, it was only these that clashed.

To Reproduce Steps to reproduce the behavior:

  1. Go to '5e char sheet
  2. Click on any item to roll an attack or other ability
  3. see error- no items appear on the chat log

Expected behavior I would have expected a roll on the chat log as normal.

Screenshots image

Browser: chrome

Foundry Version: v11.315

Game System: 5e 3.1.2

KnifeSalmon commented 4 months ago

Having same issue here. And this bug only happens for Attack (Item) and Spell Attack rolls. (Ability checks and saving throws seems to be fine.) This bug will trigger when Ready Set Roll is activated with Theatre Inserts. When without Ready Set Roll, The roll seems to work fine, but chat avatar in log is showing as player's avatar, not avatar from character sheet.

Also noticed that, when character is on stage, everything seems to work without problems or errors.

With Ready Set Roll & Character not on stage : Triggering the bug. not working

With Ready Set Roll & Character on stage: Works normally. working

Default roll & Character not on stage: The roll works, but the chat log avatar is from player's, not from character sheet. Normal roll Without Staging

Default roll & Character on stage: Works normally. Normal roll With Staging

Modules