search

League-of-Foundry-Developers / fvtt-module-theatre

GNU General Public License v3.0
30 stars 39 forks source link

V1.20.0 Update for Foundry v9 #77

Closed Geekswordsman closed 2 years ago

Geekswordsman commented 2 years ago

Creating v1.20.0, which makes Theatre Inserts compatible with v9 by fixing two issues (one error, one warning) that was preventing it from functioning within v9.

Added keybinding to new command - alt-s - which toggles all selected tokens with the stage.

Due to keybinding and changes, this new version is no longer compatible with Foundry v0.8.

megahead11 commented 2 years ago

I'll need to consult a couple folks before I make the decision to merge this PR. We just had some patches put in recently to make compatibility for v9, so I am mildly confused about this PR.

megahead11 commented 2 years ago

Out of curiosity, why did this PR remove the auto-hide bar setting we recently added? There a few things I noticed being removed with this PR.

megahead11 commented 2 years ago

Updating the module's version (not compatible version) in the module.json is unnecessary because this repo uses an automated release system with tags. (It's the reason the recent release is 2.0.3 and not 1.19.x)

Geekswordsman commented 2 years ago

Likely any new feature was removed because the original fork did not include it - which is odd as I grabbed from the latest. I'll look to rebase and rebuild it when I get a chance.