League-of-Foundry-Developers / fvtt-module-trigger-happy

Trigger Happy! FVTT Triggering system
Creative Commons Attribution 4.0 International
28 stars 12 forks source link

Upgrade of the project, add compatibility with Tagger, Journal, Stairway, SoundLink and other features #58

Closed p4535992 closed 2 years ago

p4535992 commented 3 years ago

With this PR I add the possibility to set triggers on the Notes / JournalEntry in the canvas.

The code works, but there is BUG.... to remedy an incompatibility with other modules at the time of the "mouse down" event together with the core setting "Left-Click to Release Object" active, it is necessary that if a token is selected on that event it remains at the event of "mouse up" still selected.

Unfortunately I have not found any other solution than to temporarily set the "Left-Click to Release Object" setting to false and then reset it to the original state at the "mouse up" event.

Maybe you can find a "smarter" solution.

tposney commented 3 years ago

Apologies for the delay in looking at this. I'll get to it this week

p4535992 commented 2 years ago

Add many new features here the full list:

There is some known issues (check out the README Known issue paragraph)

Made a bunch of test, but i'm only one guy and i usually made some mistake, here you can download the beta version from my fork for anyone want to help me with some tests . Just install the module using this ref

https://raw.githubusercontent.com/p4535992/fvtt-module-trigger-happy/master/module-dev.json

Cheers.

tposney commented 2 years ago

I confess to only skimming the commit, but it looks good to me. I'd ask tat over the next couple of weeks you also keep an eye out on the issues list (I noticed you do that anyway) just in case anything new comes about.

tposney commented 2 years ago

Do you have a foundry discord handle? So I can properly acknowledge your work? If you want to be added as a maintainer of trigger happy let me know - I'd be happy to add you. More than happy that you are listed in the authors section of the module.json.

p4535992 commented 2 years ago

Discord username: 4535992#1766 Sure you can add me like a collaborator of the github project if you want. Attention: classic.. the Tagger module version 1.2.1 (10 hour ago) just broke my Tagger integration i will open a new pr this evening after some test

tposney commented 2 years ago

You are now added - go for it. And thanks for the work - it's much appreciated.