League-of-Foundry-Developers / fvtt-module-trigger-happy

Trigger Happy! FVTT Triggering system
Creative Commons Attribution 4.0 International
28 stars 12 forks source link

Add custom html rendering for the TinyMCE editor #77

Closed Turreaux closed 2 years ago

Turreaux commented 2 years ago

Everytime I try to create a trigger using the @ I get an error saying unknown tag. I have turned tagger off and on, the line for enable tagger is blank. Please help.

Turreaux commented 2 years ago

If I drag and drop the actor to the journal it will load just fine, but if I try to key in a specific token. It doesn't recognize that.

p4535992 commented 2 years ago

Can you share your text journal ? Can copy and paste (or made a screenshot) of the error ? What version of Foundry are you using ? What browser are you using ?

Turreaux commented 2 years ago

image image image image Foundry Version 0.8.9 Browser: Chrome 96.0.4664.110

p4535992 commented 2 years ago

a ok sorry I misunderstood your doubt, the word "tag" made me think of the integration with the "Tagger" module. Yes Tinymce does not render the keywords used by the default module such as @Trigger[XXX] or @TOKEN[YYYY].

As soon as I find some time I wanted to do as for the "Sound Link" module and add the custom rendering, but it's not a real mistake your macro should still work anyway.

Turreaux commented 2 years ago

The triggers still do not work. If I drag the actor into the journal it will accept that as valid but still gives the error on the @trigger[click] and does not work when I click on the token. My guess is because I am referencing the Actor and not the Token but I can't figure out how to drag the individual token into the journal entry since typing it in does not work.

On Wed, Dec 22, 2021 at 8:48 AM 4535992 @.***> wrote:

a ok sorry I misunderstood your doubt, the word "tag" made me think of the integration with the "Tagger" module. Yes Tinymce does not render the keywords used by the default module such as @trigger https://github.com/trigger[XXX] or @token https://github.com/token [YYYY].

As soon as I find some time I wanted to do as for the "Sound Link" module and add the custom rendering, but it's not a real mistake your macro should still work anyway.

— Reply to this email directly, view it on GitHub https://github.com/League-of-Foundry-Developers/fvtt-module-trigger-happy/issues/77#issuecomment-999630487, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXAIPNXX5F7RLHCR4LQGECTUSHQKVANCNFSM5KRJ5JRA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: <League-of-Foundry-Developers/fvtt-module-trigger-happy/issues/77/999630487 @github.com>

p4535992 commented 2 years ago

is work with @Actor, but on the canvas/scene must be present a token (the one you click) linked to that actor, make sure there is a actor reference on the token configuration for the association token-actor. Just for be sure pass me the text of your journal i will test and give you confirmation

ss

Turreaux commented 2 years ago

Here is the journal text: @Actor[m0DkIJTnaEHJ0fyy]{OGB} @Trigger[Click] @Folder[A8JURtYEbxkZnodD]{Into the Wilds Forest}

Both token and actor are named OGB with the Link Actor Data box checked.

I have screenshots from a previous attempt that was giving the same issue at this link: https://www.reddit.com/r/FoundryVTT/comments/quihqw/trigger_happy_trigger_not_working/ https://www.reddit.com/r/FoundryVTT/comments/quihqw/trigger_happy_trigger_not_working/

Foundry version 0.8.9 using system DnD5e 1.5.6

On Sat, Jan 1, 2022 at 3:02 AM 4535992 @.***> wrote:

is work with @Actor https://github.com/Actor, but on the canavs/scenemust be present a token be linked to that actor, make sure the checkbox "Linkded to daùta" is check on the token configuration. Just for be sure pass me the text of your journal i will test and give you confirmation

— Reply to this email directly, view it on GitHub https://github.com/League-of-Foundry-Developers/fvtt-module-trigger-happy/issues/77#issuecomment-1003528890, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXAIPNR5YP3KP4RWYWVDNZTUT27LZANCNFSM5KRJ5JRA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: <League-of-Foundry-Developers/fvtt-module-trigger-happy/issues/77/1003528890 @github.com>

p4535992 commented 2 years ago

Can I ask you if you have read the README of the project? or if something in the documentation confuses you?

as for the screenshots of the reddit I highlight this:

The macro screenshot doesn't make any sense I don't know where you got the idea ... the module only ever worked with journalentry in the journals sidebar.

The @Item does not exist as a 'trigger', but only as an 'effect' so placing it as the first element of the line makes no sense. Look at the READEME table where I highlight all the valid triggres.

Finally I confirm that the line of code you passed is correct, my example works perfectly I report it to you below for confrontation:

@Actor[es5E8fb1jso36zbH]{Guard}@Trigger[click]@Folder[ejReto73e8wCeehk]{CM - DnD5 Cheatsheet}

the module is case insestive for the key elements so the following line work either:

@Actor[es5E8fb1jso36zbH]{Guard}@trigger[click]@folder[ejReto73e8wCeehk]{CM - DnD5 Cheatsheet}

Make sure the trigger happy button (the one on the left see image on the README) is active.

and I'm sorry in the previous comment I said something wrong, to make the trigger work with the @Actor annotation YOU DON'T NEED TO SET THE 'Link Actor Data' only the 'Represented Actor' parameter, like in the image i pass to you before.

Cheers.