League-of-Foundry-Developers / simplefog

A module for FoundryVTT that lets you draw fog of war manually
MIT License
18 stars 15 forks source link

Scene can't be rendered just for players, error on console #14

Closed JJBocanegra closed 3 years ago

JJBocanegra commented 3 years ago

I'm having a problem when I'm with the players on another scene and change to this concrete scene.

How to recreate

  1. Player P is on scene "Taberna de la Canción Élfica" (any other scene is valid)
  2. I change the scene to "Termas (Con paredes y simplefog)" (attached Problematic map.zip)
  3. The player sees a black screen but I can see the scene
  4. The player need to refresh the browser to see the scene

Investigation

This is what I see when the new scene change has loaded, the player is showed on the previous scene. image

When the player open the console, he sees this error: image

The problem seems to be on js/sightLayerUpdate.js file, line 19 while trying to access the property x of the object p: image

Here are the guilty variables values when the error happens: image

And that's all I can do without knowing how the module works :( hope it helps tracking the problem.

If you need more help I can create a world with the recreation of the bug with the needed scenes and modules ;)

crhampton1 commented 3 years ago

Sorry for delay, I have been sick. Back at it now working on next update and will hopefully have this bug fixed then!

JJBocanegra commented 3 years ago

Sorry to hear that, I hope you are better now, this isn't a top priority bug after all ;)

crhampton1 commented 3 years ago

Okay, I could not replicate. However, I think I found the issue and it was in a feature that hasn't worked since Foundry updated their new layer system, so I just removed it. Can you give it a try and see if you still have issues. I have a few other ideas if that doesn't work.

Thanks!

JJBocanegra commented 3 years ago

It seems to work perfect now, thanks!!