League-of-Foundry-Developers / simplefog

A module for FoundryVTT that lets you draw fog of war manually
MIT License
18 stars 15 forks source link

Z Layering Token/Tile/Drawing Maps #75

Open BardCicero opened 2 years ago

BardCicero commented 2 years ago

I am not sure the Visibility Settings are working as described, as well as an issue with Layering Masks.

I was searching for a way to have Tokens show above the Fog Layer. So I was searching within the Visibility Settings and Visibility Threshold and could not find a way to change those settings to have anything change regarding a player's point of view. Including different variations of Lighting/Token Vision/Fog Exploration/and Reveal Fog"

I also came across this odd issues regarding Overhead Tiles and Drawing:

image

A Tile indicated not Overhead works as far as I believe SimpleFog desires it. But when you change the tile to an overhead tile it masks the Drawing Layer: image Even though it is still below the Fog Layer.

I believe an enhancement may exist related to: https://github.com/League-of-Foundry-Developers/simplefog/issues/67#issue-1272909563

Or just allowing an "Overhead Tile" to be visible Above the Fog Layer so users have a way to show images on top of the Fog Image for a variety of use cases.

It seems all of these cases may be related to the Fog's Z Layer though I'm not sure exactly how.

UranusBytes commented 2 years ago

There is indeed something quirky happening with the fog zindex. I'm trying to work through it now.

As of right now, I've got it to where if you set the SimpleFog zindex to 190, a background tile is rendered below the fog, a foreground tile is rendered above the fog, and drawing is rendered below the fog.

An overhead tile will always render over a drawing, and a background tile below a drawing; that's native foundry behavior.

I'll try to get a patch out soon for further testing...

jalspaugh3 commented 2 years ago

Also noticing something weird with the Z index. No matter what I set SimpleFog's zindex too, the fog is always over everything -- tokens, shapes, notes, whatever. While moving the slider around I'll notice that certain things will briefly appear on top of the fog, but immediately glitch back underneath.

Looking forward to a potential patch!