League-of-Foundry-Developers / torch

Simple torch module for Foundry VTT
10 stars 20 forks source link

Fold in functionality of Drop My Torch #12

Open derekstucki opened 2 years ago

derekstucki commented 2 years ago

My module, Drop My Torch, has partially overlapping functionality with Torch. Please contact me at derekstucki@gmail.com if you'd be interested in me rolling the DMT functionality missing from Torch into it.

lupestro commented 2 years ago

You may like what I implemented this weekend. I'll see if I can pull together a vid of it and send it along for your critique.

lupestro commented 2 years ago

I just published v2.0.0 for Foundry V10 and would be interested in your take on what I've done. I think I covered the bases but let me know if you see anything I missed. (For now, only run FoundryVTT 10 on a test server. It is still very much a work in progress and various systems and modules may corrupt data or cause hangs that require restarts. This will improve sharply over the coming few weeks.)

steveculshaw commented 1 year ago

I've installed v2.1.3 and I can't see anyway to "drop my torch" :-(

Am I missing something?

lupestro commented 1 year ago

So for dropping it, you mean placing it as a standalone object? I had thought of "Drop My Torch" as primarily adding light sources, but I somehow missed the implications of the name.

As for setting torches loose from the character, we haven't done that. All the lighting is "self" lighting as yet. I've thought about what it would take to implement a drop button on the context menu, creating an actor token that carries the light source. That then leaves the follow-on tasks of picking it up again or any party member extinguishing it.

I agree it would be useful and improve immersion. I just haven't gotten there yet and have spent a couple of months absorbing the implications of the new possibilities in the work I recently did. So I will concede that and add the enhancement tag to this ticket so I don't overlook it.

steveculshaw commented 1 year ago

Yeah, I was thinking of the use case, e.g., the character has a torch in hand, sees a monster, wants to drop the torch, and go into melee with their two handed sword.

Thanks for sharing the module

lupestro commented 1 year ago

A torch will light and stay lit where the player is standing when it is in inventory. We're not checking any further system bits like whether it is in hand, in a bag, etc. When they drop the torch, is it extinguished? You can just click the button to turn it off before you swing your big honking' sword. :) What we can't do for you, at least at present, is to model your character dancing away from a torch lying on the ground and shedding light from there. A feature worth having, but not a feature we have.

Philosophically, Foundry VTT is a system to use for playing a game, not necessarily a deeply enforced simulation of every game mechanic, and we're very much in keeping with that. Aside from the one consideration mentioned, I think there's nothing that will prevent you from handling the scenario you describe purely as "Theatre of the Mind".

apoapostolov commented 1 year ago

In my own games (PF2 but the approach is agnostic) I solve the issue by creating actors with predefined light for torch, light spell or other sources, and drop them on the map when a player asks to drop or place light in a specific location. There are no many downsides of this approach other than these system Light actors need to be configured so players can see them and drag them to the map instead of asking the DM every time.

image

image

steveculshaw commented 1 year ago

@apoapostolov Sounds promising suggestion. Ta