League-of-Foundry-Developers / torch

Simple torch module for Foundry VTT
10 stars 20 forks source link

Dancing Lights not configurable in v10 #18

Closed lupestro closed 2 years ago

lupestro commented 2 years ago

@Airwrecker drew this to my attention. The properties for dim and bright lights in tokens were moved into their own substructure in v9. We fixed this everywhere except where we were setting up the Dancing Light tokens. So it is broken in the main stream.

It also turns out to be broken in the v10 stream. Not only are the properties of the tokens wrong, they aren't taking into account the settings provided from the light sources configuration. So this needs a fix in the v10 stream as well.

lupestro commented 2 years ago

I did a little further investigation. While the properties passed to do the update are the older ones, something in the system is doing the adjustment internally, and the dancing lights are coming up as 10 ft dim light, as specified, so as best I can tell there isn't a bug in this area in v9.

However, I did just add the code to make the lighting for Dancing Lights configurable in v10 and this code will be in the next drop. While I was at it, in v10, I used the light, sight, and texture sub-structures so it reflects the delivered structure of a v10 token document.

lupestro commented 2 years ago

Issue for v10 fixed in v2.1.0. Having re-read the comment on the other issue by @Airwrecker, it turns out the request was for configurable settings rather than noting a bug in v9. Since the Dancing Lights are configurable now, I will close this issue.