League-of-Foundry-Developers / torch

Simple torch module for Foundry VTT
10 stars 20 forks source link

Torch Button Missing For Half Of Players #30

Closed PhluXx1 closed 1 month ago

PhluXx1 commented 1 year ago

Half of my players are missing the torch button and cannot activate any light. When I as the DM try to do it for them it works normally.

lupestro commented 1 year ago

The way Torch works has changed for several systems to be based on inventory as it was before in D&D5e:

Because some get the torch button and some don't, my initial guess would be that some of your users may not have acquired a recognized light source as equipment.

To help me help you:

PhluXx1 commented 1 year ago

The issue was that they lacked a torch in their inventory. Is it possible to disable this requirement not seeing one in module settings?

image

lupestro commented 1 year ago

@PhluXx1 That looks like the version of the module that last shipped for v9. Are you running v9 of Foundry?

I don't see us enhancing the capabilities for the module for v9. In v9, DnD5e was the only system that was inventory driven. All the others worked more or less the way you want DnD5e to work. In DnD5e, it looked first for the Dancing Lights or Light cantrips and then for Torch equipment. If torches were found, using one decremented the inventory. When the final one was extinguished, you got a slash through the button and couldn't ignite more until you got more.

In the enhanced module for v10, there are a lot more options and opportunities, fulfilling the features that a lot of people asked for - more light sources on more systems, with different effects suitable to the source. The user can select which light source from their inventory they want to use, and the list is game-extensible. Systems for which no specific light sources are known now provide a "self" light source with the dim/light values you set in the config, which approximates the level of support non-DnD5e systems got in v9.

However, what we have for v10 today won't reduce any system with an inventory-driven approach to a non-inventory-driven approach. This just wasn't on our radar to consider.

I can see a clean way to do this for v10, I think. It could be in-scope to use the user light sources JSON to tell it to ignore any light sources already defined for a system. I can't say when we might do this, though. I'd rather know first whether anything in v10 gives you a better way forward that would make this no longer a need.

PhluXx1 commented 1 year ago

Yes, I'm still running the last version of 9 as I'm still waiting on some modules to get a v10 update. Thanks for the info it's a shame that's a lacking feature. Thanks.

lupestro commented 11 months ago

@PhluXx1 Have you had a chance to move up to v10 and more recent versions of Torch? Is everything working for you now?