lupestro
commented
10 months ago Doing it as one request is fine. Reviewing the code, I was startled to see the change for the angle on Starfinder:
- Looking up cones on p. 268, I see that cones are measured at 90 degrees, with the size being the length along the edges, so you are correct. I have no idea where I got 35 from.
- This is different from the way a cone is defined in 5e, where the length was defined up the middle with the width increasing by 1 for each 1 of distance. This led us a merry chase over in the issues, dipping into spherical (physics) vs. flat ended (map mechanics) cones, eventually resolving to a compromise of a 57 degree angle.
- I just looked and Pathfinder 2e uses the same definition as Starfinder - same house, so no surprise there. I expect the 90 degrees will affect the Bullseye Lantern in PF2e and the Bullseye and Miner's lanterns in PF1e. Once I've merged this PR, I'll fix those.
Good catch on the new Close button, too! I'll credit you for all this stuff.
Translates the help messages into German. Additionally adds core localisation support for the 'close' button, which was previously not localised. Also adds a new source for Starfinder and expands the angle to 90 degrees which is closer to RAW.
Let me know, if I rather shall split this into two separate merge requests.