lupestro
commented
2 months ago Message heard and noted. The trouble is that the coding involved in providing a GUI for it is a fair amount of work. However, I can do a lot pretty easily to improve the user experience for light source files.
Over the last year or so, it's become pretty clear that the light configs are a struggle. The only problem in the json you posted is the comma toward the bottom of the file, so you only "missed it by that much." Right now, you get no idea when you offer up a JSON file whether the JSON you supply is valid. That's a serious user experience problem.
The module should provide human-readable validation of the JSON file when you click the button to use it. Fortunately, there is a handy npm module called ajv that I can use to do the heavy lifting for that. Further, it can validate against a schema so it can tell not only if it is a valid JSON file, but if it is a valid light source file. Based on recent feedback, this is probably more important than any other feature I could add and is more important than any work I do for the fudge-rpg system. Consider it top-of-stack.
To broaden the definition of "right", I'm also considering supporting json5 and perhaps yaml, provided I can get a comparable level of validation. I'll need to experiment, so I'll get the ajv support out there first.
Cedric-the-Destroyer
It would be endlessly helpful, to be able to attach items/item ID to the settings, to create custom light sources. As it stands, I spent 3 hours tonight trying to get the json to work, and while I recognize I am probably doing it wrong, I really tried to make it work. My solution as of tonight is to just disable this mod, and do it the way PF2E expects it to be done, which is far less nuanced than I could wish, and is much less convenient
In any case, thank you for the module, and your time.
torch_settings.json