League-of-Foundry-Developers / torch

Simple torch module for Foundry VTT
10 stars 20 forks source link

support WWN system #88

Closed fuzzymuzzi closed 2 weeks ago

fuzzymuzzi commented 3 weeks ago

Wanted to use this module for the system and game i am running. Figured others might benefit as well

lupestro commented 2 weeks ago

@fuzzymuzzi Can you clarify: What is "type": "art"? Is it a kind of Item? Hopefully yes, because Torch only works with the token's actor's item collection to find light sources. One way or another, assuming that I hear from you that it is a kind of item, by tomorrow I should be able to get this in there.

All the stuff I originally entered had just the types "equipment" and "cantrip" (not spell, as the schema description text indicates incorrectly.) Both of these "types" for Torch purposes are Item objects at the Foundry level with item types specific to the game system. It was not our intention for our "type" to track these types. Since then, "ose" and "demonlord" have used "item", probably thinking the "type" was supposed to have its conventional Foundry meaning. If you omit the type, it will use "equipment" as its default value, so that's a perfectly valid thing to do, too.

Why did I specify a "type" at all?

I think, maybe at one time, I was thinking about supporting consumable spells, so I needed to know a difference, but it became clear that, while consuming an item has a cross-system meaning, the meaning of consuming a spell would always be very system specific, so I abandoned that idea.

It appears that this field isn't materially used by the code for anything at all now so maybe I can abandon it entirely down the line. (I can enter a ticket for that.) In the current schema, it is defined simply as a string with no constrained set of values, so using "art" as a value is as valid under the rules as any other.

fuzzymuzzi commented 2 weeks ago

@fuzzymuzzi Can you clarify: What is "type": "art"? Is it a kind of Item? Hopefully yes, because Torch only works with the token's actor's item collection to find light sources. One way or another, assuming that I hear from you that it is a kind of item, by tomorrow I should be able to get this in there.

Hey @lupestro, yes an "art" is a kind of item in foundry. They represent the "traits" or non physical objects a character can posses in the system.

I don't quite recall if there was an issue without it, but I doubt it, since you question if it is used at all. More likely that I added it following "ose" and "demonlord" examples.

lupestro commented 2 weeks ago

Published in torch 2.15.0. Thanks!