LeagueOfPoro / CapsuleFarmerEvolved

Automatically drops from lolesports.com and farm Esports Capsules
Other
813 stars 128 forks source link

[Suggestion]: Add Location Geocode/Area to Config #152

Closed WeirdPtr closed 1 year ago

WeirdPtr commented 1 year ago

What is your idea?

Currently the Location Geocode/Area that is being sent to Riot is "CZ". I think it would be beneficial to have the ability for customization in the config.yaml.

Location-01

What should happen?

Add a option to the config.yaml containing a geocode/area. If not provided or invalid use a predefined geocode/area.

My request is not a question

alepouna commented 1 year ago

I believe this is purely for tracking and analytics on Riot's end. Let them think Czechia is watching a billion of streams :P

wneel commented 1 year ago

Hey, I would like to do it but where's area is specified we can see two values :

"geolocation": {
    "code": "CZ",
    "area": "EU"
}

If we can find different available language codes on this page, I have no idea of where does the area code come from, it does not match the routing codes

So please where can we find all possible codes and area values?

WeirdPtr commented 1 year ago

Hey, I would like to do it but where's area is specified we can see two values :

"geolocation": {
    "code": "CZ",
    "area": "EU"
}

If we can find different available language codes on this page, I have no idea of where does the area code come from, it does not match the routing codes

So please where can we find all possible codes and area values?

These would most likely be these Alpha-2 here: Country Codes

Or if you really want to be sure use the uppercase ones you provided here.

As for the area i cant say.

Penguax commented 1 year ago

Lolesports page accesses https://lolesports.com/location.js

when manually checking the page it spits out this for me window._geoinfo = {"code":"US","area":"NA","locale":"en-US"}

Would be a good way of adding this in instead of using a list that may not be accurate to riot games.