LeagueOfPoro / PoroLobby

Create 5v5 League of Legends lobby with bots
39 stars 8 forks source link

Bug in parsing of token #3

Closed bogglez closed 1 year ago

bogglez commented 1 year ago

https://github.com/LeagueOfPoro/PoroLobby/blob/a0fd835679378c86d33a77d68092b37363e861d9/ConnectionManager.py#L43

Same bug as in lcu-driver: the split must be limited to one time only. It’s possible for the value to contain equal signs (padding in base64). Sometimes the token will contain them and requests will fail.

LeagueOfPoro commented 1 year ago

Thanks, fixed