search

LeaguePHP / LeagueWrap

League of Legend API wrapper
MIT License
20 stars 7 forks source link

[Request] Updated Riot API #16

Open SeaRoth opened 7 years ago

SeaRoth commented 7 years ago

Will you be updating to SummonerV3 and MatchV3?

image

m1so commented 7 years ago

I'm not sure what the plan is yet as the deprecation window is opened until the end of July. There have been significant changes in the API, such as removal of the batch calls, some endpoint and Dto changes, new rate limiting, etc. so a complete rewrite might be a possibility. However PRs are greatly appreciated at all times. If you have any questions or ideas for the update feel free to contact me on the Riot API Discord and I will try to get back to you as soon as possible.

alabama commented 7 years ago

any updates so far?

alabama commented 7 years ago

I would start working on the V3 branch and switch to the new API, any advise from you @m1so?

m1so commented 7 years ago

Have a look at https://github.com/LeaguePHP/LeagueWrap/tree/v3 and the 'Roadmap' project https://github.com/LeaguePHP/LeagueWrap/projects/1

I've also prepared an async client which will be used to do batch requests as they are deprecated now (see Stats for usage).

alabama commented 7 years ago

can you add me to members, i finished with a change for summoner api v3 and would like to commit to the V3 branch, that you can see how i would do this.

i could also just branch from V3 and we do this via pull-requests

m1so commented 7 years ago

Yep, we can also move the discussion to the PR

alabama commented 7 years ago

17 here we go

m1so commented 7 years ago

Honestly I'm thinking about recreating the lib from scratch and removing some features which aren't widely used (like attaching static data) or using dtos (most people use ->raw() in their questions anyway) to have a lightweight implementation. Also the rate limiting is a mess and I'd rather rework it to be pluggable with psr standard as well as provide integration for popular frameworks.

alabama commented 7 years ago

I thinks recreating the lib is a good idea. Problem is the the deadline from riot. So the older api endpoints V1/V2 will be deprecated and not used after July 24th. So it's not much time for recreating everything.

m1so commented 7 years ago

Here is my initial implementation of v3 with lots of breaking changes and possible todos https://github.com/m1so/LeagueWrap, it should be up on packagist.

All the endpoints and Dto class are autogenerated so there is a lot of missing docblocks, but every endpoint is implemented and supports batch requests.