search

LeaguePHP / LeagueWrap

League of Legend API wrapper
MIT License
20 stars 7 forks source link

Changes to the Summoner-API: #17

Closed alabama closed 7 years ago

alabama commented 7 years ago

added accountId requests changed all requests to V3 riot api format changed info() to work with single summonerId or summonerName only

adjusted testcases for api summoner adjusted json files to match right response form riot api

removed batch requests completely removed ListMaxException throws removed masteries and runes requests to separate class

alabama commented 7 years ago

so ofc the tests failed, cause i just wanted to show you, how i would structure that

m1so commented 7 years ago

What's the point of removing batch calls? I think it's more convenient for the end-users if we keep them (and the api), guzzle supports async requests with curl_multi and the rate limits have been increased. From the previous discussion:

I've also prepared an async client which will be used to do batch requests as they are deprecated now (see Stats for usage).

alabama commented 7 years ago

Disable batch calls roadmap In the roadmap there is a point about disabling the batch calls ...