Gangplank skills

[CLAassistant]

All committers have signed the CLA.

[MingSaber976]

GangPlankE you can use GameScript to addParticle(if you know what to do),and about give buffs to ally,you can follow "Taric R" to make AOE buff.

[MingSaber976]

GangPlank W should be scale by AP, not AD. We don't have "RestoreHealth" function, please fix it

[MingSaber976]

About R spell, you can use for() to make codes shorter.

[MingSaber976]

Gangplank W you can use owner.Stats.CurrentHealth += healing number; to restore health.

[MingSaber976]

GangplabkE BuffHudVisual and Particle should be in GameScript, else it will be weird, like particles didn't remove on other people.

[MingSaber976]

in GangplankW, that Game script have "removeAfter" things, you could add that and remove owner.RemoveGameScript(); function.

[xTeJk]

GangplabkE BuffHudVisual and Particle should be in GameScript, else it will be weird, like particles didn't remove on other people.

AddBuffHUDVisual should be defined as var and then removed by RemoveBuffHUDVisual(..); in timer?

[MingSaber976]

But you use foreach(), mean all units in the range. But you coded as removeParticle on one's(not sure who is the one).

[MingSaber976]

So coded in GameScript then it won't have confusion and it will be more readable.

[MingSaber976]

Check the IGameScript( not the buff one)construction is the current version, because you don't have "IChampion, ISpell,IAttackableUnit" type ( all without the "I" word)

[MingSaber976]

CreateTimer should be vars number, not 0.5f (else it will happen at the same time)

[xTeJk]

if (unit is IChampion || unit is Minion || unit is Monster) Im not sure about this construction (shouldnt be IMinion and IMonster?)

About E foreach particle removing also.

I've checked GameScript but still dont understand how removeAfter; is working and what i should paste in code

[xTeJk]

CreateTimer should be vars number, not 0.5f (else it will happen at the same time)

So it should be CreateTimer(0.5, () => instead of CreateTimer(0.5f, () => am i right?

[MingSaber976]

Gangplank visualHud and Particles should be in "Buffs/GangplankE.cs", so after time, it will disappear on units(remember foreach() function, you can use that)

[MingSaber976]

@xTeJk No, like this example.

for(float p = 0.0f; p<=12; p += 0.5f)
{
  CreateTimer(p,()=>
  {
    ............
  });
}

[MingSaber976]

And test in LeagueSandbox make sure it all works or not, most coding problems were solved.

[MingSaber976]

And please remove GangplankR because the spells construction not that perfect(especially CreateTimer() function,the developers don't recommended to use that)

[xTeJk]

And please remove GangplankR because the spells construction not that perfect(especially CreateTimer() function,the developers don't recommended to use that)

Sure.

And test in LeagueSandbox make sure it all works or not, most coding problems were solved.

Everything is working fine.

[MingSaber976]

GangplankE have CreateTimer please remove it and if you want removeParticle, code them in the BuffGameScript(Buffs/GangplankE.cs)

[MingSaber976]

About GangplankW, that code won't over Maximum health,tested before.

[MingSaber976]

You didn't removeParticle(if in game it still exist) Try make "private Particle" to show particles and also can be remove.

[MingSaber976]

And in buffGameScript, you don't have "owner", try get "owner" from spell file, or just use unit(if it won't make game crash)

[xTeJk]

I do not know if these conditions for checking health points are correct, so please correct the code.

And in buffGameScript, you don't have "owner", try get "owner" from spell file, or just use unit(if it won't make game crash)

public void OnActivate(IObjAIBase unit, ISpell ownerSpell)

ownerSpell isnt a owner definition in buffgamescript?

[MingSaber976]

ownerSpell is Spell class So you need the "IChampion" class to fit "owner"

[MingSaber976]

Health point codes looks fine,but the middle one should be remove(because it didn't do the things)