search

LeagueSandbox / LeagueSandbox-Default

LeagueSandbox's Default Content Package
70 stars 97 forks source link

Corrected Miss Fortune's Json file. #54

Closed yasinallahdev closed 6 years ago

yasinallahdev commented 6 years ago

MissFortune.json was using 'Draw a Bead' as a passive to load; this passive belongs to Tristana. Miss Fortune's own passive should be 'MissFortuneStrut', which this file change corrects.

yasinallahdev commented 6 years ago

That's rather odd, then. I guess I can partially understand (Phreak mentioned in Miss Fortune's Champion Spotlight that some of Tristana's assets had to be used for the spotlight since Miss Fortune's own had not been finished) why this could be happening, but it still strikes me as odd, given she would be loading Tristana's passive by default. I checked Tristana's own json file and the spells folder to verify (MissFortuneStrut.json appears to contain the data for Miss Fortune's passive, and Draw a Bead.json also exists on its own). I'll keep looking into it, though.

MythicManiac commented 6 years ago

I can merge this as is, I'm just saying it'll be overwritten by the next export (as these files come directly from the game fiels)

yasinallahdev commented 6 years ago

That's understandable. I'm just confused that this is what's in the actual files, since at first glance it seems like it could cause problems internally. Hard to actually say for sure, though.

moonshadow565 commented 6 years ago

Old/corrupted league was used in generation and this was fixed in #56