search

LeagueSharp / LeagueSharp.Common

188 stars 244 forks source link

Utility.Delay action causing connection issues #48

Closed xKurisu closed 10 years ago

xKurisu commented 10 years ago

Assemblies using utility.delay may cause NA users to disconnect.

ghost commented 10 years ago

Do you have any proof to these claims or are you just saying this? Because this sounds pretty far-fetched.

xKurisu commented 10 years ago

Well I noticed it when writing assembly, as soon as I put it in and it gets called I get the attempting to reconnect, this may explain why I had problem updating my Fiora assembly because it uses this callback also

But idk could only be affecting some people, for now I avoid it

ghost commented 10 years ago

What are you doing in the callback? That is probably what is causing the issue.

xKurisu commented 10 years ago

Something like, Utility.DelayAction.Add(Game.Ping + 100, () => (Stuff));

Simple stuff like Q.Cast or Game.PrintChat.

ghost commented 10 years ago

Well there's your problem. Even though you are using delay action you are still queuing a large number of actions in a small amount of time. You need to add a delay.