LeagueToolkit / cslol-manager

GNU General Public License v3.0
429 stars 91 forks source link

Bringing back windows 7 support #102

Closed thewaybackiswayahead closed 3 months ago

thewaybackiswayahead commented 10 months ago

Recompiled Qt 5.15.2 (it says 5.15.0 in files because i was lazy to change) from source based on this link https://gist.github.com/rsouth/f029ce1bd093dc573afa8f48846e471c with added option in configure command 'no-d3d12' to exclude directx12 features from it, uploaded the resulting files zipped across 13 volumes. Removed condition for 'trash PC support' since that's what the entire fork is about, its just ON forever. Changes to buildit.yaml to adjust for the changed file structure around new Qt files. (just unzip instead of download from external link)

moonshadow565 commented 10 months ago

I'm not going to merge this but i am going to leave this PR open and you are free to provide fork and binary download for fork under one simple condition: You are responsible for any and all issues that arise from your fork and you are not to forward support requests our way.

As to for why i am not planning on supporting windows= 7.. While i agree that windows 10 is generally shittier user experience over windows 7, it does provide benefits (that i consider absolutely essential from OS) to developer:

Both of those requirements lead to many issues that make it harder to develop and properly support users who report "bugs". For example, people are usually incapable of installing vendor provided drivers and are often extracting the tool in unexpected and outright retarded locations. All this results in useless bug reports only providing a phone picture of error message with logs intentionally blurred out for "privacy" reasons. If you want someone to blame for this, blame microsoft for not providing basic of basics in their windows 7 API and gatekeeping them on windows 10+ instead.

For anyone not satisfied with this repsonse who does not want to install windows 10 i recommend installing linux. And reporting any issues with software running under wine, i will fix those.