search

LeagueToolkit / cslol-manager

GNU General Public License v3.0
429 stars 91 forks source link

GUI freezes when loading a heavy mod (zip) #7

Closed Diegovsky closed 2 years ago

Diegovsky commented 2 years ago

This could be confusing to new users as they might think something went wrong. Moving processing out of the UI thread could solve this

moonshadow565 commented 2 years ago

all processing should already be done on a separate thread

Diegovsky commented 2 years ago

I get a dialog saying the window has stopped responding but I can see the progress bar going. I'm not familiar with Qt, but looking at the code it seems it's using workers to delegate work. Maybe they aren't running in a separate thread and instead asynchronously

moonshadow565 commented 2 years ago

where are you draging zip from(is it special place like temp directory)? hopefully once crauzer rewrites fantome zips wont be an issue anymore we found out the hard way how terrible of idea using zips is

Diegovsky commented 2 years ago

My Downloads folder. I have an ssd btw so I'm not sure that's an I/O issue. It could be some proccessing going on as I was importing an old mod format (basically an ASSETS folder with lots of textures and models for characters).

Regarding the .zip issue: I think allowing people to load folders directly is good enough. I see that the code extracts the zip and then loads the extracted folder.

Diegovsky commented 2 years ago

Also, on an unrelated note: Why do you use a custom implementation for File? It seems Qt has this cool QFile class that might be better for you guys and reduces maintenance costs

moonshadow565 commented 2 years ago

You can already import folders as if they were unziped mods. Not using any of Qt in file processing logic. Once fantome gets updated this app will likely be obsolete anyways: https://github.com/LoL-Fantome/Fantome/tree/maui

Diegovsky commented 2 years ago

Oh, ok. Thanks for theses amazing projects anyway :D