LeagueToolkit / cslol-manager

GNU General Public License v3.0
429 stars 91 forks source link

feat(releases): automatically run `buildit` and `builditmac` workflows upon releases and upload the artifacts #90

Closed xnus-kernel closed 1 month ago

xnus-kernel commented 12 months ago

This PR proposes a change to the buildit.yaml and builditmac.yaml GH action workflows; now they're dispatched upon releases being:

It also removes the workflow_dispatch condition. If necessary, the workflow_dispatch condition can be added in again, for convenience sake – however it won't upload the artifacts to the release, of course.

[^1]: please do note that with this to properly compile latest upstream source, the tag must be updated to the specific commit SHA (i.e: git push -f <REMOTE> <SHA>:<TAG>), as well as removing the old binaries, of course.

moonshadow565 commented 10 months ago

Any update on this PR?

moonshadow565 commented 1 month ago

fixed with 28f3c2eb389bcf29909c5269110c6929f93f9e7d