search

LeagueToolkit / league-toolkit

The home of tooling for League of Legends
GNU Affero General Public License v3.0
0 stars 1 forks source link

feat: rework modpkg format #24

Open Crauzer opened 2 weeks ago

Crauzer commented 2 weeks ago
Crauzer commented 1 week ago

btw I'm probably in favor of doing our own serialization for metadata and strings, there seem to be differences between msgpack libraries in how they handle enums for example, so I'd like to avoid potential issues there

moonshadow565 commented 1 week ago

btw I'm probably in favor of doing our own serialization for metadata and strings, there seem to be differences between msgpack libraries in how they handle enums for example, so I'd like to avoid potential issues there

what about having metadata and strings table being just chunks instead of dedicated fields?

Crauzer commented 1 week ago

what about having metadata and strings table being just chunks instead of dedicated fields?

Sure, I don't think it should cause too much trouble for the user