search

LeagueToolkit / league-toolkit

The home of tooling for League of Legends
GNU Affero General Public License v3.0
0 stars 1 forks source link

bin support #6

Closed alanpq closed 3 weeks ago

alanpq commented 3 months ago

This branch has the commits from #5, so not mergable until that is closed. There are also still some improvements that can be made - it would be nice to reduce the boilerplate around PropertyValueEnum more.

alanpq commented 3 weeks ago

Tentatively marking bin writing as complete, round trip test is working but won't be confident in its soundness until I dogfood it more with hexbelt or something

Crauzer commented 3 weeks ago

Is it ready to merge then ?

alanpq commented 3 weeks ago

Is it ready to merge then ?

Yeah I'd say so