LeahJB / SimplyP

Simple hydrology, sediment and phosphorus catchment-scale model
MIT License
10 stars 3 forks source link

Increase flexibility in terms of sub-catchment and reach routing #6

Closed LeahJB closed 5 years ago

LeahJB commented 5 years ago

One likely use for the model is to calculate P fluxes to receiving waterbodies such as lakes or estuaries. In this case, there may be subcatchments which drain directly to the waterbody, not to each other. E.g. the main tributary to the waterbody might be a number of subcatchments and associated reaches which drain one into the other and then into the waterbody, then there may be a number of other subcatchments which drain directly to the waterbody. To do this, need a more flexible subcatchment structure. It would also be nice to add in the possibility of summing all SC inputs which flow directly to the waterbody together to produce a single timeseries of inputs to the waterbody. For e.g. driving a lake model.

One option would be to add a "Sub-catchment structure" sheet to the parameter file, with e.g. headers 'Sub-catchment number', 'Upstream sub-catchment' (the number of the sub-catchment directly upstream, N/A if none), 'Include in final output flux calculation?' (0 for any upstream SCs, 1 for any SCs whose output volumes and masses should be summed together to provide a final flux to a receiving WB). Then need to take this structure into account in the code.

LeahJB commented 5 years ago

Done - added a new sheet to the parameter Excel file in which the sub-catchment structure is defined, with accompanying documentation. Amended the code and basic testing carried out.