LeanThoughts / risk-rating-model

0 stars 1 forks source link

Account Conduct Risk Check Box : Change Logic in opposite manner #67

Closed sajeevkhan closed 5 years ago

sajeevkhan commented 5 years ago

By default, account conduct risk will be set in the risk model template as "Not Applicable". I have modified the template accordingly.

  1. Rename checkbox label as "Account Conduct Risk Applicable"
  2. If checkbox is checked, then the tab should be enable for data entry.

Also, In cases where there are two Risk Types - E.g. "Project Impl. Risk" and "Post Impl. Risk", the account conduct risk may be applicable EITHER for One or for BOTH. We can check the "isAccountConductRiskComponentPresent" attribute of RiskType to determine whether the checkbox is to be enabled or not.

Issue as reported by PFS testers The tab of account conduct is named as "ACCOUNT CONDUCT NOT APPLICABLE". It should be renamed as "ACCOUNT CONDUCT APPLICABLE". First one doesn’t look optically good and is not in line with other check box options like Rating Modifiers and Parental Notch up. Request to change the Lable name as "ACCOUNT CONDUCT APPLICABLE"; if the check box is ticked, it would mean account conduct is Applicable & if the check box is un-ticked, it would mean account conduct is NOT Applicable.