search

LeandroSQ / android-ble-made-easy

An Android Library for handling Bluetooth Low Energy on Android Easy
MIT License
88 stars 29 forks source link

MTU value not being updated #42

Closed Marco012 closed 11 months ago

Marco012 commented 12 months ago

Hello,

The requestMTU(bytes) method is not requesting the MTU with the bytes we are sending, but instead is just requesting with its current MTU value. I was having issues with this, and changing the "mtu" to "bytes" in the following line fixed it.

https://github.com/LeandroSQ/android-ble-made-easy/blob/b483665e044e19c67fb4ce9e79381f040cb1f0d2/lib/src/main/java/quevedo/soares/leandro/blemadeeasy/BluetoothConnection.kt#L311C26-L311C26

LeandroSQ commented 11 months ago

First of all, thank you for your issue and interest on the library. Secondly, great catch!

Do you want to open a PR for this? So your name would appear as a contributor :)

Marco012 commented 11 months ago

The library is great!

I opened a PR with this fix.

Continue with your great work 😁

LeandroSQ commented 11 months ago

I appreciate your words! Thank you

And welcome as a contributor, your name is already showing up as an official contributor to this project.