fix: add sessions volume to survice restarts

[antonanders]

problem description: We host leantime in kubernetes, which restarts our deployment multiple times a day and currently forces all uses to login again. A simple persistent session storage would already fix this issue for us.

changes:

• adds a mountable docker volume for php sessions
• uses explicit docker-hub images, which fixes buildah/podman builds for us

[sgissi]

@marcelfolaron Can you take a look at this one? A few possibilities: 1) Use as-is which shouldn't break anything as far as I know 2) Build /usr/local/etc/php/conf.d/custom.ini in "start.sh" (e.g. read from environment variables and append to file) 3) Control setting in Leantime itself via session_save_path() before session_start in https://github.com/Leantime/leantime/blob/4c059a091cb25fc3c220c4d69b3057d5a11053bc/src/core/class.session.php#L73

[marcelfolaron]

Thanks, so would we have to add the definition for session_save_path into core and make it a config var? I guess we could leave it in the config.ini.

Now will this break existing instances? Will the volume be mounted during an update (sorry I am no expert in docker and had to rely on community knowledge here)?

[sgissi]

This PR adds session.save_path into config.ini, no further changes needed and should work without issues. It does introduce a behavior change to all users but really shouldn't cause any trouble. A less intrusive way would be to call session_save_path("path") before session_start() in core/class.session.php, I did a quick test and it worked well. It can be made a config option that defaults to the current system setting (a call to session_save_path() without parameters will return it) and only overwrite if needed. Both approaches are fine but second is more flexible.

[sgissi]

Thanks @marcelfolaron, are you planning on tagging 2.1.7? Seems like Dockerhub has 2.1.4 and "latest" only.

[marcelfolaron]

Yeah, let me tag it today.

On Tue, Feb 9, 2021, 00:02 Silvio Gissi notifications@github.com wrote:

Thanks @marcelfolaron https://github.com/marcelfolaron, are you planning on tagging 2.1.7? Seems like Dockerhub has 2.1.4 and "latest" only.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Leantime/docker-leantime/pull/31#issuecomment-775664847, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALG4EFVWSGV2RCUFDIX52IDS6C6VZANCNFSM4XBHEKOQ .

[sgissi]

Thanks for tagging, but I believe you did for 2.1.6 instead of 2.1.7 :)

[marcelfolaron]

Sorry, just created the 2.1.7 tag as well

On Tue, Feb 9, 2021, 15:55 Silvio Gissi notifications@github.com wrote:

Thanks for tagging, but I believe you did for 2.1.6 instead of 2.1.7 :)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Leantime/docker-leantime/pull/31#issuecomment-776238373, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALG4EFQ5OCQ4QCTPQW3OUO3S6GOMXANCNFSM4XBHEKOQ .