search

Leantime / docker-leantime

Official Docker Image for Leantime https://leantime.io
GNU Affero General Public License v3.0
190 stars 86 forks source link

MySQL 8.0 upgrade #53

Closed phulstaert closed 2 years ago

phulstaert commented 2 years ago

MySQL 5.7 has one year of support left; MySQL 8.0 has 4 years left. MySQL 8.0 is already 4 years old, so has matured enough to be used by lots op projects. As long as you use UTF-8 (or utf8mb4), MySQL 8.0 is as fast or up to 4 times as fast as its predecessor. (especially in high load situations) Also, MySQL 8.0 is available for ARM devices; MySQL 5.7 not. (at least when talking about docker containers)

marcelfolaron commented 2 years ago

Added latest on the last PR.

phulstaert commented 2 years ago

I would strongly advise not to use 'latest'. This would mean that all the docker-leantime users over the world could experience a breaking change when a new release of MySQL comes out.

phulstaert commented 2 years ago

@marcelfolaron, I just checked (just a sanity check) even WordPress and other big applications always use an explicit version. You never know if there are breaking changes. If you use 8.0, then you will get all the security updates (8.0.1, 8.0.2, ...) but an 8.1 could break things.

The same is true for PHP. We know it works with PHP 8.0, but I have a lot of applications where the PHP 8.1 doesn't work anymore.

marcelfolaron commented 2 years ago

Yeah I agree with that. Let’s put 8.0 as the version number.

On Sat, Aug 13, 2022 at 10:18 AM Peter Hulstaert @.***> wrote:

@marcelfolaron https://github.com/marcelfolaron, I just checked (just a sanity check) even WordPress and other big applications always use an explicit version. You never know if there are breaking changes. If you use 8.0, then you will get all the security updates (8.0.1, 8.0.2, ...) but an 8.1 could break things.

The same is true for PHP. We know it works with PHP 8.0, but I have a lot of applications where the PHP 8.1 doesn't work anymore.

— Reply to this email directly, view it on GitHub https://github.com/Leantime/docker-leantime/pull/53#issuecomment-1214166893, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALG4EFUYWAFEMXNY7DKUELDVY6VEPANCNFSM554A5RRQ . You are receiving this because you were mentioned.Message ID: @.***>