search

Leantime / leantime

Leantime is a goals focused project management system for non-project managers. Building with ADHD, Autism, and dyslexia in mind.
https://leantime.io
GNU Affero General Public License v3.0
4.23k stars 561 forks source link

Update Tickets.php to include editorId in getAllBySearchCriteria #2536

Closed rqi14 closed 3 weeks ago

rqi14 commented 4 weeks ago

In the original version, authorId is included but editorId is not included. As editor first name last name are both included, it does not make sense not to have editorId included.

Link to ticket

None

Description

In the original version, authorId is included but editorId is not included. As editor first name last name are both included, it does not make sense not to have editorId included.

Screenshot of the result

None

Checklist

If your code does not pass the requirements on the checklist, you should add a comment explaining why this change should be exempt from the list.

Additional comments or questions

If you have any further comments or questions for the reviewer, please add them here.

marcelfolaron commented 4 weeks ago

editorId is included in line 401 of that file. Or am I missing something?

marcelfolaron commented 3 weeks ago

Closing this for now. Let me know if there is an issue with using editorId as a field from above

rqi14 commented 3 weeks ago

editorId is included in line 401 of that file. Or am I missing something?

Hi. Thanks for pointing it out. You are absolutely right.