Learn-Build-Teach / learn-build-teach-discord-bot

53 stars 17 forks source link

Reorganizing and removing bot dependency in db file #58

Closed jamesqquick closed 2 years ago

jamesqquick commented 2 years ago

Ignore the branch name. This is about reorganizing code and separating out dependencies.

mhuggins7278 commented 2 years ago

Overall this makes a lot of sense the only thing that felt a little weird was the new utils/users.ts file but I can also see it both ways especially if we think we might have more utility type functions on users at some point

jamesqquick commented 2 years ago

Yeah that was the one part that felt weird to me. Based on some difficulties I had with setting up testing, I am thinking keeping core discord stuff and core db stuff separate from each other. That's what inspired this. I'm still not 100% sold either