search

Learn-by-doing / bitstarter

A crowd funding website that uses bitcoin
MIT License
23 stars 28 forks source link

#91 dropDatabaseTables to include sessions table #93

Closed karliatto closed 7 years ago

karliatto commented 7 years ago

Added the session table to the models to delete from bistarter_test database, there maybe more elegant ways how to solve it but I found it simple and clear. any other idea?

chill117 commented 7 years ago

I am seeing this error when running the integration tests (controller tests):

Error: ER_NO_SUCH_TABLE: Table 'bitstarter_test.sessions' doesn't exist

The tests still pass, but I think the error is cause for concern.

Instead of dropping the sessions table, we should probably just clear all the sessions with sessionStore.clear(). See session middleware where this is setup.

chill117 commented 7 years ago

@karliatto Still a problem here with dropping the sessions table. See my previous comment for details.