Cowboy-coder
commented
12 years ago This fixes the issue somewhat: https://github.com/Cowboy-coder/tobi/commit/fd733a38ef0a282104f12b4e0502d1e0743b5d29
Some tests are still failing though.
Open Cowboy-coder opened 12 years ago
Cowboy-coder
commented
12 years ago This fixes the issue somewhat: https://github.com/Cowboy-coder/tobi/commit/fd733a38ef0a282104f12b4e0502d1e0743b5d29
Some tests are still failing though.
benadida
commented
12 years ago Even the simplest examples seem to fail in node 0.6.5 for me, even with your commit. Are you seeing stuff work with that commit?
UPDATE: whoops, never mind, problem on my end, working okay now.
iangreenleaf
commented
12 years ago That commit worked for me. I also put together a bare-bones test case to reproduce this issue.
secobarbital
commented
12 years ago +1 Patch worked for me too
tj
commented
12 years ago I cant even get jsdom to install for 0.6.x, either that or my npm is borked
secobarbital
commented
12 years ago hmm worked for me on Mac OS X 10.7.3 and Ubuntu 11.04; node 0.6.7; npm 1.1.1. Also had to change the devDevependency line for express because the 2.3.X and 2.4.X are gone from npm, then everything installed fine:
├─┬ connect@1.8.5
│ ├── formidable@1.0.8
│ └── mime@1.2.4
├─┬ express@2.5.8
│ ├── mime@1.2.4
│ └── mkdirp@0.3.0
├── htmlparser@1.7.4
├─┬ jsdom@0.2.10
│ ├── contextify@0.0.7
│ ├── cssom@0.2.2
│ └── request@2.9.100
├─┬ mocha@0.12.0
│ ├── commander@0.5.2
│ ├── debug@0.5.0
│ └── growl@1.4.1
├── qs@0.4.2
└── should@0.5.1 BTW the above fix still causes timeouts in my tests. It looks like server.fd no longer exists in 0.6, so this works for me:
diff --git a/lib/browser.js b/lib/browser.js
index 0e39fb5..d7a2675 100644
--- a/lib/browser.js
+++ b/lib/browser.js
@@ -170,6 +170,7 @@ Browser.prototype.request = function(method, path, options, fn, saveHistory){
if (!server.__started) {
server.listen(server.__port = ++startingPort, host, function(){
process.nextTick(function(){
+ server.fd || (server.fd = true)
server.__deferred.forEach(function(args){
self.request.apply(self, args);
});
dperezrada
commented
12 years ago secobarbital That worked perfect for me. Thanks
I'm using Mac OS X 10.6.8
I also had to change
"express": "2.3.x"to"express": ">= 2.3.0"in devDependencies before doingnpm installMaybe 0.6.X isn't supported yet, but I assume it should work because of this
"engines": { "node": ">= 0.4.x < 0.7.0"inpackacke.json