X-Forwarded-Proto set to 'httpshttps' (bug in node-http-proxy)

LearnBoost / up

Zero-downtime reloads and requests load balancer based on distribute.

540 stars 73 forks source link

X-Forwarded-Proto set to 'httpshttps' (bug in node-http-proxy) #38

Closed bkw closed 2 years ago

bkw commented 12 years ago

For the record: nodejitsu/node-http-proxy#266 affects distribute, and thus it affects up. The outcome is that behind a reverse proxy that terminates ssl, the header X-Forwarded-Proto is set to "httpshttps", which can give weird results, ie. (express req.protocol).

As soon as nodejitsu releases a fixed package, someone should update distrubute's dependencies and the ones of up. Or reference a fork in the meantime.

rauchg commented 12 years ago

/cc @indexzero

bkw commented 12 years ago

sorry, I mistyped the issue number. I meant 266 instead of 226 (now corrected). Please excuse the confusion.

indexzero commented 12 years ago

I'll try to take a look at this over the weekend. There are a couple of bugs I'd like to fix with 0.8 now available.