LearnBoost / up

Zero-downtime reloads and requests load balancer based on distribute.
540 stars 73 forks source link

Moved requires loop up so it precedes the loading of the server file. #43

Closed pharcosyle closed 12 years ago

pharcosyle commented 12 years ago

I've changed worker.js so options.requires are require()'ed before the server file gets loaded. Currently running an app that uses Up with coffeescript directly doesn't work, this would allow child processes to load .coffee files (and more generally, feel the impact of any module that changes the behavior of require())

I don't think there would be any negative impact from this change, if there is let me know.

Thanks a bunch! Chris

rauchg commented 12 years ago

At the very least let's add a comment block explaining why we're doing this.

pharcosyle commented 12 years ago

Sure thing! Descriptive enough?

rauchg commented 12 years ago

Perfect. Thanks