search

LearnBoost / websocket.io

329 stars 59 forks source link

Fixed a few bugs, updated parser (actually pulled from easy-websocket), fixed tests #12

Closed einaros closed 12 years ago

einaros commented 12 years ago

This library should be closer to autobahn compatibility too, now.

rauchg commented 12 years ago

Let's switch easy-websocket from devDependencies to dependencies, do a proper require, and make sure its public API from the easy-websocket side.

einaros commented 12 years ago

I was hoping to spark some debate there. The require is probably a bad idea as it is right now, since there's no guarantee that easy-websocket is actually in the local node_modules.

Regarding pulling the receiver in as a whole, I'm conflicted. As @3rd-Eden pointed out elsewhere, maintaining multiple versions of inevitably the same source code is a lot of work, so sharing it somehow isn't a bad idea. Requiring it from within another library, however, seems silly.

What if I separate the hybi parsers into an entirely separate library, which I maintain and publish on npm, and utilize in all projects requiring it?

rauchg commented 12 years ago

The parsers are always needed for a client or a server, so my vote is that we keep them in either through public API.